Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit: Remove the trailing period after printing $KUDO_HOME #782

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

yankcrime
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

The trailing period is too easy to pick up when selecting text in your terminal to copy.

Also it looks weird.

Does this PR introduce a user-facing change?:

NONE

The trailing period is too easy to pick up when selecting text in your
terminal to copy.
@kudo-ci
Copy link

kudo-ci commented Sep 10, 2019

@yankcrime: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test e7a8949 link /test test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kudo-ci kudo-ci added the lgtm label Sep 10, 2019
@kudo-ci
Copy link

kudo-ci commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kensipe, yankcrime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kensipe kensipe merged commit 6d024e5 into kudobuilder:master Sep 10, 2019
@yankcrime yankcrime deleted the kudo_home_dot branch September 30, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants