Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Master releases via Github Actions #820

Merged
merged 11 commits into from
Sep 13, 2019
Merged

Conversation

gerred
Copy link
Member

@gerred gerred commented Sep 13, 2019

This adds a workflow and an action for generating out a KUDO controller Docker image with Github actions based on master.

Sorry about committing node_modules, it's required for JS actions, which is required for outputs. :(

@gerred
Copy link
Member Author

gerred commented Sep 13, 2019

Actually, I can just make a separate action in a separate repo for current time.

@kudo-ci kudo-ci added size/M and removed size/XXL labels Sep 13, 2019
@gerred
Copy link
Member Author

gerred commented Sep 13, 2019

/kind enhancement

@gerred
Copy link
Member Author

gerred commented Sep 13, 2019

Fixes #125

@gerred gerred requested a review from kensipe September 13, 2019 16:53
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

- master
jobs:
build:
runs-on: ubuntu-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure we want ubuntu version changing underneath us?

@kudo-ci
Copy link

kudo-ci commented Sep 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gerred, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kudo-ci kudo-ci merged commit c81392a into kudobuilder:master Sep 13, 2019
@gerred
Copy link
Member Author

gerred commented Sep 13, 2019

what the hell @kudo-ci

@gerred
Copy link
Member Author

gerred commented Sep 13, 2019

@kensipe yes that's fine, it's the virtual machine underneath. See https://help.github.com/en/articles/virtual-environments-for-github-actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants