Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code (kudoctl/helpers) #865

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Remove dead code (kudoctl/helpers) #865

merged 1 commit into from
Sep 30, 2019

Conversation

alenkacz
Copy link
Contributor

What this PR does / why we need it:
Not used for some time -> removed

zen-dog
zen-dog approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, we don't plan on having CLI interractions in the near future? I'm fine with removing this code, one can always bring it back from the git history.

@alenkacz
Copy link
Contributor Author

@zen-dog yeah, we had it at one point and then removed it. We could always revive from the git history if it's easier than writing from scratch :)

@kensipe kensipe merged commit a4aedaf into master Sep 30, 2019
@kensipe kensipe deleted the av/remove-dead-code-helper branch September 30, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alenkacz @kensipe @zen-dog