Little bit of polishing in the execution engine #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerred
approved these changes
Oct 3, 2019
zen-dog
approved these changes
Oct 3, 2019
| @@ -25,22 +25,20 @@ import ( | |||
|
|
|||
| const basePath = "/kustomize" | |||
|
|
|||
| // metadata contains metadata associated with current PlanExecution | |||
| // metadata contains metadata associated with current plan being executed | |||
| type metadata struct { | |||
There was a problem hiding this comment.
You could also make metadata exportable since we would use it in the tasker branch but that's a soft nit
zen-dog
reviewed
Oct 3, 2019
| @@ -25,22 +25,20 @@ import ( | |||
|
|
|||
| const basePath = "/kustomize" | |||
|
|
|||
| // metadata contains metadata associated with current PlanExecution | |||
| // metadata contains metadata associated with current plan being executed | |||
| type metadata struct { | |||
There was a problem hiding this comment.
Also, metadata as a name is pretty broad. wdyt about engineMetadata? or maybe this one is more of executionMetadata and the existing one is more like kudoResourceMetadata?
zen-dog
added a commit
that referenced
this pull request
Oct 3, 2019
Proposed implementation does *not* make use of the `MutliTask` pipeline. It rather calls sideeffect free methods like `render`, `enhance` or `delete`. Templates, params, client are part of the context. Metadata is not yet everything it needs to be but #892 fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Yesterday when working on tasker with @zen-dog we identified these small things that were left behind in the refactoring, especially embedding the one metadata in the other seems like a natural choice.