Add feature gate scaffold #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
holding until we land the dep changes |
zen-dog
approved these changes
Oct 9, 2019
|
I had this working at 1.14 deps but then I updated them to 1.16 and it won't build atm. :) Actually, I can probably back out and push these back down to 1.14, so nm. |
|
@gerred what's the status of this PR? need any help here? |
|
merge to the latest master and resolved issues with go.mod |
kensipe
approved these changes
Jan 17, 2020
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Co-authored-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't introduce any features, but it's available when we need them. Should be used like: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go to add features.