Make Instance name deterministic #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
|
@yankcrime nice! You also need to change the description I adjusted with #943 |
yankcrime
force-pushed
the
deterministic_instance_names
branch
from
b5e2ec0
to
136f7e9
Compare
|
Ah good shout, thanks @alenkacz! |
alenkacz
approved these changes
Oct 17, 2019
nfnt
requested changes
Oct 17, 2019
yankcrime
force-pushed
the
deterministic_instance_names
branch
2 times, most recently
from
ba7ea39
to
91aa068
Compare
nfnt
approved these changes
Oct 17, 2019
zen-dog
requested changes
Oct 21, 2019
yankcrime
force-pushed
the
deterministic_instance_names
branch
2 times, most recently
from
4b78cfa
to
3458af5
Compare
yankcrime
force-pushed
the
deterministic_instance_names
branch
from
3458af5
to
f23dc8f
Compare
Remove the random string suffixed onto the end of instance names, instead using a suffix of `-instance`. Users can use the `--instance` option to provide a unique name if they so wish. The removal of the random string suffixed onto instance names means that the associated test can be simplified.
yankcrime
force-pushed
the
deterministic_instance_names
branch
from
f23dc8f
to
b04e2fe
Compare
gerred
approved these changes
Oct 24, 2019
yankcrime
added a commit
to yankcrime/operators
that referenced
this pull request
Nov 4, 2019
With the introduction of [deterministic instance names](kudobuilder/kudo#960) we can simplify some of the starting defaults such as the connection string for ZooKeeper.
zmalik
pushed a commit
to kudobuilder/operators
that referenced
this pull request
Nov 5, 2019
With the introduction of [deterministic instance names](kudobuilder/kudo#960) we can simplify some of the starting defaults such as the connection string for ZooKeeper.
porridge
added
release/highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the random string suffixed onto the end of instance names, instead using a suffix of
-instance. Users can use the--instanceoption to provide a unique name if they so wish.Fixes #948