User-configurable request timeouts #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankcrime
force-pushed
the
955_install_timeout
branch
from
b365caa
to
35fddeb
Compare
yankcrime
changed the title
yankcrime
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
|
@yankcrime wdyt about doing one more refactoring here to create a client function that just takes the settings struct (just a helper in the CLI packages)? DRY up the longer arity function a little bit. |
yankcrime
force-pushed
the
955_install_timeout
branch
2 times, most recently
from
986c34a
to
dd0b858
Compare
|
@gerred How's this look? |
yankcrime
force-pushed
the
955_install_timeout
branch
from
dd0b858
to
6fb95ad
Compare
Add an option to allow the user to specify the KUDO client's request timeout. The hardcoded default of 3 seconds causes problems for users whose connectivity to a target service involves relatively significant amounts of latency. Mirror the behaviour of `kubectl` by setting this to 0.
yankcrime
force-pushed
the
955_install_timeout
branch
from
6fb95ad
to
17959b5
Compare
|
lgtm @yankcrime |
gerred
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add an option (
--request-timeout) to allow the user to specify the KUDO client's requesttimeout. The hardcoded default of 3 seconds causes problems for users whose connectivity to a target service involves relatively significant amounts of latency.
Mirror the behaviour of
kubectlby copying the option itself and setting this to by default to 0 (no timeout).Fixes #955