Setup golangci-lint as default linter framework #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golanci-lint provides all linters that were previously used in a single binary. A default configuration has been provided that matches the existing linter configuration but also adds a few more linters. Furthermore a pre-commit configuration is provided.
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
zen-dog
reviewed
Oct 24, 2019
gerred
approved these changes
Oct 24, 2019
|
@nfnt you removed the Does this mean that |
|
@porridge Good catch! The instructions are obsolete, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
golanci-lint is a meta-linter that provides all linters that were previously used in a single binary. Running this from a single binary results in improved performance and consistent linter output. Furthermore it will allow us to enable additional linters in the future by adding the to
.golanci.yml. A default configuration has been provided that matches the existing linter configuration but also adds a few more linters. Furthermore a pre-commit configuration is provided.Fixes #795