make lint doesn't install golinter if found one locally

[zen-dog]

Additionally, renamed code-formatting CircleCI job to lint.

[alenkacz]

LGTM :) Even better solution would be to wrap it in a shell script and do something similar to what we do here https://github.com/dcos/metronome/blob/master/ci/si_install_deps.sh#L19

[zen-dog]

LGTM :) Even better solution would be to wrap it in a shell script and do something similar to what we do here https://github.com/dcos/metronome/blob/master/ci/si_install_deps.sh#L19

How does this sentence start with "Even better solution" and ends with "shell script"? 😆

[alenkacz]

LGTM :) Even better solution would be to wrap it in a shell script and do something similar to what we do here https://github.com/dcos/metronome/blob/master/ci/si_install_deps.sh#L19

How does this sentence start with "Even better solution" and ends with "shell script"? 😆

You can choose another technology/language 😝

[nfnt]

Try this:

.PHONY: lint
lint:
ifeq (, $(shell which golangci-lint))
	go get github.com/golangci/golangci-lint/cmd/golangci-lint
endif
	golangci-lint run

And it would be great if we could pin the version of golangci-lint, e.g., add

GOLANGCILINT_VERSION ?= "v1.21.0"

at the beginning of Makefile and later

	go get github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCILINT_VERSION)

[zen-dog]

And it would be great if we could pin the version of golangci-lint, e.g., add

As discussed offline, we want to keep it up-to-date and should any discrepancies between local and CI environment occur, we can revisit this.

[nfnt]

🚢