Command Scripts from TestSuite or TestStep #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tl get ns foo; do sleep 1; done Signed-off-by: Ken Sipe <kensipe@gmail.com> adding script capabilities Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
ANeumann82,
gerred,
jbarrick-mesosphere,
porridge,
zen-dog and
zmalik
as code owners
Signed-off-by: Ken Sipe <kensipe@gmail.com>
porridge
approved these changes
May 22, 2020
There was a problem hiding this comment.
Does it work on Windows? Should it use sh there?
Should we explicitly mention that namespaced does not apply in this case?
Not sure about the environment expansion. I'd mention that it is up to the shell in this case, as opposed to command where we do it, but I don't see it mentioned either.
ANeumann82
approved these changes
May 22, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously scripts added to
command:would fail such as:Both of these options fail... to provide some ability to script a
script:is provided as a commands option such as:This works for TestSuite and TestStep
Fixes: #50
Co-authored-by: Marcin Owsiany mowsiany@D2iQ.com
Co-authored-by: Andreas Neumann aneumann@mesosphere.com
Signed-off-by: Ken Sipe kensipe@gmail.com