Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teststep apply, assert and errors can now take urls, files or folder #123

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented May 29, 2020

TestStep Apply, Errors and Asserts can now have urls (in addition to folders and files)

apiVersion: kudo.dev/v1beta1
kind: TestStep
apply:
  - https://mesosphere.github.io/kubeaddons/bundle.yaml

Is completely legit now.

There was an interesting situation with the kubeaddons url as well. It has a file headers of:

# DO NOT EDIT: this file is generated

---
apiVersion: apiextensions.k8s.io/v1beta1

The 3 lines prior to the separator creates an unstructured object (without an error) but isn't valid. This need detection has been added to the code as well.

Signed-off-by: Ken Sipe kensipe@gmail.com

Fixes #114

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe
Copy link
Member Author

kensipe commented May 29, 2020

As a side note: it would be great to do this with manifests as well.. however today it is called manifestsDir... I think it would be best to switch to the new structure in KEP06 before adding url as an option. We should call it manifests:

Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, I'm not sure if it's a good idea that people use external files for apply/assert/error, but... They'll do it anyway :)

The PR itself lgtm

Copy link
Member

@zmalik zmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kensipe kensipe merged commit b85c5a0 into master Jun 2, 2020
@kensipe kensipe deleted the ken/url-the-things branch June 2, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply and Manifests to support URLs
3 participants