-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tail
parameter to pod collector.
#220
Conversation
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it! thanks!
the project has a dependency on testify... could you switch out the newly added dependency.. then we are good!
briefly looked into this... I see you are getting DeepEqual... is there a way to do this with our current tooling? |
value of DeepEquals
value of testify
|
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
- rather than linking to largely irrelevant `kudo`s testing guide, just mention make targets and the testify library - change the build command to one which actually builds, and remove mention of manager :-) - merge the `Testing new CLI` section into the `Build Instructions` one to avoid duplication Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
@kensipe I switched to testify and mentioned it in the contributor guide along with a couple other minor improvements there, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic! nice work!
What this PR does / why we need it:
Ability to set the number of lines to collect.
Also minor improvements to contributor guide.
Fixes #216