Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better KUTTL Testing Context #228

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Better KUTTL Testing Context #228

merged 1 commit into from
Oct 16, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Oct 15, 2020

Recent challenges by new KUTTLers, it was hard to know:

  1. Was the connection with kubernetes cluster working and
  2. Was kuttl pointing to the correct location for tests

This PR resolves that... KUTTL previously had connect failure messages with:
Bad local config

 harness.go:572: fatal error getting client: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

or bad connection with:

harness.go:572: fatal error getting client: Get "https://127.0.0.1:63473/api?timeout=32s": dial tcp 127.0.0.1:63473: connect: connection refused

However... the absence of this doesn't reinforce comfort... this PR adds the following message after a good connection:

 harness.go:274: Successful connection to cluster: https://127.0.0.1:63473

Additionally, it is hard to know if users are pointing their testsuite dir to the right location... Adding in a message that will indicates that:

harness.go:354: testsuite: /Users/kensipe/projects/playground/e2e has 1 tests

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm always up for more logging ;)

@kensipe kensipe merged commit bb81950 into main Oct 16, 2020
@kensipe kensipe deleted the test-context branch October 16, 2020 14:15
@porridge
Copy link
Member

WDYT about refusing to run a suite with 0 tests @kensipe ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants