Removing KUDO references and Warning on Deprecated use of kudo.dev #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
ANeumann82,
gerred,
jbarrick-mesosphere,
porridge,
zen-dog and
zmalik
as code owners
alenkacz
reviewed
Oct 26, 2020
| @@ -392,6 +392,9 @@ func ConvertUnstructured(in runtime.Object) (runtime.Object, error) { | |||
| // Deprecated: kudo.dev is deprecated. | |||
| kudoGroup := "kudo.dev" | |||
| kuttlGroup := "kuttl.dev" | |||
| if group == kudoGroup { | |||
There was a problem hiding this comment.
with this change, this warning is printed for all the resources from KUDO (try running KUDO tests now and you'll see). I am not sure this was the right place to put this warning to.
There was a problem hiding this comment.
👍
This function is also called when applying general resources. These could be KUDO CRDs or CRs where kudo.dev is expected.
There was a problem hiding this comment.
yeah this is what kudo tests say right now
2020/10/26 13:56:54 WARNING: kudo.dev group has been deprecated and is schedule to be removed in KUTTL 0.8.0
2020/10/26 13:56:54 WARNING: kudo.dev group has been deprecated and is schedule to be removed in KUTTL 0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ken Sipe kensipe@gmail.com