Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dependencies #25

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Bump Dependencies #25

merged 2 commits into from
Mar 23, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Mar 20, 2020

Summary:

controller-runtime to 0.5.1
kubectl to 0.17.3
controller-tools v0.2.6

Closely tied to: kudobuilder/kudo#1420
In fact the PR had more affect on testing and kuttl than on the rest of kudo.

Gotchas:

For some harness tests, I had to edit our test CRDs like:

-  name: mycrds.mycrd.k8s.io
+  name: mycrds.mycrd.example.com

With new kubectl version, the original name had multiple problems:

  • names ending with k8s.io are restricted and now require an api-approved.kubernetes.io annotation pointing to a PR which introduced them
  • adding this annotation proved challenging since we then see a new transition condition with the reason: ApprovedAnnotation thus bringing the number of status.condition s to three. These conditions would sometimes arrive out of order, however, test harness does not support the same order of elements when comparing two arrays, thus making the tests flaky. See this thread for more details.

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awfully familiar 🚢

@kensipe kensipe merged commit 92f27fd into master Mar 23, 2020
@kensipe kensipe deleted the ken/depend-upgrade branch March 23, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants