Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller-Tools and Go version Bump #255

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Dec 16, 2020

Signed-off-by: Ken Sipe kensipe@gmail.com

Signed-off-by: Ken Sipe <kensipe@gmail.com>
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we can do two more minor bumps though

@@ -31,6 +31,6 @@ require (
k8s.io/client-go v0.19.2
k8s.io/code-generator v0.19.2
sigs.k8s.io/controller-runtime v0.6.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also 0.6.4 and 0.7.0 for this. I think at least the 0.6.4 bump should be easy

go.mod Outdated Show resolved Hide resolved
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
@kensipe
Copy link
Member Author

kensipe commented Dec 17, 2020

thanks @estroz

Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe kensipe merged commit 5bfe431 into main Dec 17, 2020
@kensipe kensipe deleted the ken/controller-tool-bump branch December 17, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants