Warning for testdir Override #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
ANeumann82,
gerred,
jbarrick-mesosphere,
jmccormick2001,
porridge,
zen-dog and
zmalik
as code owners
Signed-off-by: Ken Sipe <kensipe@gmail.com>
alenkacz
approved these changes
Dec 17, 2020
pkg/kuttlctl/cmd/test.go
Outdated
| @@ -195,6 +193,7 @@ For more detailed documentation, visit: https://kuttl.dev`, | |||
| } | |||
|
|
|||
| if len(args) != 0 { | |||
| log.Println("kutt-test config testdirs is overridden with arg: ", args) | |||
There was a problem hiding this comment.
won't this end with a not nice looking log? Should we maybe rather do strings.Join(args, ",") ?
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from community is that overriding the kuttl-test.yaml config testDirs is something that needed to be in the stdout log for awareness.
Signed-off-by: Ken Sipe kensipe@gmail.com