pkg/test: allow complex "assert" and "errors" step file names #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
ANeumann82,
gerred,
jbarrick-mesosphere,
jmccormick2001,
kensipe,
porridge,
zen-dog and
zmalik
as code owners
estroz
force-pushed
the
feature/named-asserts-errors
branch
from
8e3992c
to
49b8388
Compare
|
nice! thank you sir! I like it. I will review in more detail shortly... but a quick pass looks good! |
kensipe
approved these changes
Dec 16, 2020
alenkacz
requested changes
Dec 17, 2020
There was a problem hiding this comment.
I am a bit lost here (not your fault, that's the state of the code as it was before you started working on it).
I feel like right now the file parsing logic is two places, but it's parsing the same files, right? The regexes are kind of similar but not equal 🤔 what am I missing here? Can we maybe make some cleanup in there since we're doing changes in that area already?
escapes and non-capturing groups, and permitted assert- and error- type steps to have complex names, ex. "00-assert-test-pod.yaml" Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
estroz
force-pushed
the
feature/named-asserts-errors
branch
from
49b8388
to
2441399
Compare
|
looking to see if @alenkacz is good... thanks Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves file name matching regexps by adding meta char escapes and non-capturing groups, and permitts assert- and error-type steps to have complex names, ex. "00-assert-test-pod.yaml"
Signed-off-by: Eric Stroczynski estroczy@redhat.com