-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harness: add JSON tag for the suppress
config option
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
ANeumann82,
gerred,
jbarrick-mesosphere,
jmccormick2001,
kensipe,
porridge,
zen-dog and
zmalik
as code owners
December 17, 2020 03:32
estroz
force-pushed
the
feature/suppress-config
branch
from
December 17, 2020 03:33
f97d404
to
ecc6550
Compare
alenkacz
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you have time/energy it would be great to add the json mapping for other fields as well :)
pkg/kuttlctl/cmd/test.go: de-duplicate options.Suppress and --suppress-log values Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
estroz
force-pushed
the
feature/suppress-config
branch
from
December 17, 2020 09:26
ecc6550
to
805eded
Compare
kensipe
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
estroz
pushed a commit
to estroz/kuttl.dev
that referenced
this pull request
Dec 17, 2020
Update reference after kudobuilder/kuttl#259 merged.
estroz
pushed a commit
to estroz/kuttl.dev
that referenced
this pull request
Dec 17, 2020
Update reference after kudobuilder/kuttl#259 merged. Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
estroz
pushed a commit
to estroz/kuttl.dev
that referenced
this pull request
Dec 17, 2020
Update reference after kudobuilder/kuttl#259 merged. Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
alenkacz
pushed a commit
to kudobuilder/kuttl.dev
that referenced
this pull request
Dec 18, 2020
Update reference after kudobuilder/kuttl#259 merged. Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds JSON tags to fields missing them in
TestSuite
.Signed-off-by: Eric Stroczynski estroczy@redhat.com