Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harness: add JSON tag for the suppress config option #259

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Dec 17, 2020

What this PR does / why we need it:
This PR adds JSON tags to fields missing them in TestSuite.

Signed-off-by: Eric Stroczynski estroczy@redhat.com

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you have time/energy it would be great to add the json mapping for other fields as well :)

pkg/apis/testharness/v1beta1/test_types.go Outdated Show resolved Hide resolved
pkg/kuttlctl/cmd/test.go: de-duplicate options.Suppress and
--suppress-log values

Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kensipe kensipe merged commit b04aaca into kudobuilder:main Dec 17, 2020
estroz pushed a commit to estroz/kuttl.dev that referenced this pull request Dec 17, 2020
estroz pushed a commit to estroz/kuttl.dev that referenced this pull request Dec 17, 2020
Update reference after kudobuilder/kuttl#259 merged.

Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
estroz pushed a commit to estroz/kuttl.dev that referenced this pull request Dec 17, 2020
Update reference after kudobuilder/kuttl#259 merged.

Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
alenkacz pushed a commit to kudobuilder/kuttl.dev that referenced this pull request Dec 18, 2020
Update reference after kudobuilder/kuttl#259 merged.

Signed-off-by: Eric Stroczynski <estroczy@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants