Support multiple Kubernetes clusters by supporting kubeconfig in test steps #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… steps Adds a `kubeconfig` setting to the TestStep API allowing an alternative kubeconfig path to be used for asserts and applies in a test step. Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com>
jbarrick-mesosphere
requested review from
alenkacz,
ANeumann82,
jmccormick2001 and
kensipe
as code owners
|
Any update wrt this PR? ;) FYI I have a rebased branch here: https://github.com/chhsia0/kuttl/tree/multi-cluster |
|
One thing I noticed is that the kubeconfig path is related to the root of the test dir, not the test step dir, which is inconsistent w/ |
|
ping @kensipe @alenkacz @jbarrick-mesosphere. I also added a new commit in my fork to address the above path resolution consistency issue: chhsia0@ba20535 |
|
thanks for the ping @chhsia0 I will look at this later in the day. |
takirala
added a commit
that referenced
this pull request
May 14, 2021
… steps - Follow up for #266 (#291) * Support multiple Kubernetes clusters by supporting kubeconfig in test steps Adds a `kubeconfig` setting to the TestStep API allowing an alternative kubeconfig path to be used for asserts and applies in a test step. Signed-off-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com> * Resolve relative kubeconfig path against test step dir. Signed-off-by: Tarun Gupta Akirala <tarugupta.92@gmail.com> * fix linter errors Signed-off-by: Tarun Gupta Akirala <tarugupta.92@gmail.com> * fix variable name collision with package imports Signed-off-by: Tarun Gupta Akirala <tarugupta.92@gmail.com> Co-authored-by: jbarrick@mesosphere.com <jbarrick@mesosphere.com> Co-authored-by: chhsia0 <chhsiao@mesosphere.io>
|
Can this be closed? |
|
this work was completed in #291 |
|
thanks @faiq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
kubeconfigsetting to the TestStep API allowing an alternativekubeconfig path to be used for asserts, errors, commands and applies in a test step.
Implements KEP-0008 (#261)
Signed-off-by: jbarrick@mesosphere.com jbarrick@mesosphere.com