Fixes Background Process Leaking Bug #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
gerred,
jbarrick-mesosphere and
zen-dog
as code owners
kensipe
commented
Mar 24, 2020
kensipe
commented
Mar 24, 2020
| bgs = append(bgs, bg) | ||
| } else { | ||
| logger.Log(stderr.String()) | ||
| logger.Log(stdout.String()) |
There was a problem hiding this comment.
no logging if background
kensipe
commented
Mar 24, 2020
|
|
||
| logger.Log(stderr.String()) | ||
| logger.Log(stdout.String()) | ||
| if bg != nil { |
There was a problem hiding this comment.
always add bg (this was the main bug)
gerred
previously approved these changes
Mar 24, 2020
zen-dog
previously requested changes
Mar 24, 2020
| @@ -393,6 +402,16 @@ func (h *Harness) Stop() { | |||
| } | |||
| } | |||
|
|
|||
| if h.bgProcesses != nil { | |||
There was a problem hiding this comment.
Fun fact, I've asked for a test for this case in the original #23 PR where this bug was introduced ;)
There was a problem hiding this comment.
@zen-dog definitely! added!
Signed-off-by: Ken Sipe <kensipe@gmail.com>
zen-dog
reviewed
Mar 25, 2020
zen-dog
reviewed
Mar 25, 2020
gerred
previously approved these changes
Mar 25, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com>
zen-dog
reviewed
Mar 25, 2020
zen-dog
reviewed
Mar 25, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com> Update pkg/test/harness.go Co-Authored-By: Aleksey Dukhovniy <adukhovniy@mesosphere.io> adding quotes to the logs Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Signed-off-by: Ken Sipe kensipe@gmail.com