Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linux arm64 for krew-index #392

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

imusmanmalik
Copy link
Contributor

Signed-off-by: imusmanmalik usmanmalik@engineer.com

Builds are present for linux arm64 and installing kuttl on linux arm64 fails.

PR at krew-index -> kubernetes-sigs/krew-index#2693

Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

assuming you need this... I will create an update for the current release

@kensipe
Copy link
Member

kensipe commented Oct 25, 2022

and thank you for this contribution!

@kensipe kensipe merged commit dd99d46 into kudobuilder:main Oct 25, 2022
@imusmanmalik
Copy link
Contributor Author

Thanks! @kensipe

@kensipe
Copy link
Member

kensipe commented Oct 25, 2022

we will be waiting for a PR merger for the support: kubernetes-sigs/krew-index#2702

@imusmanmalik
Copy link
Contributor Author

imusmanmalik commented Oct 25, 2022

@kensipe I had created a PR already but probably i am not a Plugin author so its a bit hard for my PR to get merged in i believe.

kubernetes-sigs/krew-index#2693

iblancasa pushed a commit to iblancasa/kuttl that referenced this pull request Nov 17, 2022
Signed-off-by: imusmanmalik <usmanmalik@engineer.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants