core deps bump #438
Merged
core deps bump #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
evenh
reviewed
Dec 13, 2022
| @@ -224,7 +224,7 @@ func (r *RetryClient) Patch(ctx context.Context, obj client.Object, patch client | |||
| // Get retrieves an obj for the given object key from the Kubernetes Cluster. | |||
| // obj must be a struct pointer so that obj can be updated with the response | |||
| // returned by the Server. | |||
| func (r *RetryClient) Get(ctx context.Context, key client.ObjectKey, obj client.Object) error { | |||
| func (r *RetryClient) Get(ctx context.Context, key client.ObjectKey, obj client.Object, opts ...client.GetOption) error { | |||
| return Retry(ctx, func(ctx context.Context) error { | |||
| return r.Client.Get(ctx, key, obj) | |||
There was a problem hiding this comment.
Shouldn't opts be passed to the r.Client.Get call like the CRUD functions?
There was a problem hiding this comment.
double checking... thanks for the watchful eye
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version updates for:
This bump brings the k8s dependencies to v0.25.4