Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy documentation over from kuttl.dev repo to kuttl #490

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

porridge
Copy link
Member

@porridge porridge commented Oct 9, 2023

What this PR does:

A an almost verbatim copy of the docs in the kuttl.dev repository master branch, plus:

The first commit is an exact copy of the above files. Additional commits are for minor styling changes needed to adapt to GitHub markdown flavor. This is the basic set of changes necessary. I hope additional improvements to restructure the docs and bring them up to date with the actual code will come later.

Why we need it:

The primary motivation is fixing the docs vs binary versioning conundrum: it was never clear to me whether the documentation on the kutt.dev website should correspond to the kuttl code in main or to the last released version (there are advantages and disadvantages to both approaches).

This way we can store docs close to the same version of code they correspond to - the docs on main should always match the code on main. At the same time, the docs directory at a release-versioned URL will naturally correspond to the given release.

Arguably, this commit should also modify the PR template checklist to mention that docs should be updated together with source.

Legacy docs

As for the docs still on kuttl.dev, I think we should replace them with a redirect to the docs directory in this repo to prevent confusion, as soon as we revive the website deployment pipeline. The landing page on kuttl.dev can of course stay mostly as is.

These additionally contain the changes from
kudobuilder/kuttl.dev@e1979f4
which document a feature already merged in kuttl `main`.

Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
GitHub automatically generates a ToC that seems to be hidden by default, but is
accessible using the "dotted hamburger" icon in upper right-hand corner. See
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#headings

Ideally GitHub would provide a way to have an in-line auto-generated ToC or at
some point we can investigate ways to have it semi-automatically generated.

But for now having docs with this slightly hidden ToC is better than not having
them.

Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
See PR kudobuilder#488.

Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 6ca6a62 into kudobuilder:main Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants