Make $PWD between TestStep and TestAssert commands consistent #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
added
release/highlight
release/breaking-change
release/bugfix
and removed
release/highlight
labels
porridge
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Thank you for your contribution!
A couple of nitpicks inline.
Also, now that we have this consistent, would you mind adding a note about the CWD to https://github.com/kudobuilder/kuttl/blob/main/docs/testing/reference.md#commands?
pkg/test/step_integration_test_data/assert_commands/path_script/test/script.sh
Show resolved
Hide resolved
stuggi
force-pushed
the
fix_assert_command_dir
branch
from
e1fb203
to
9c51e98
Compare
porridge
approved these changes
Jun 5, 2024
The $PWD is different when running commands in TestStep and TestAssert which makes it required e.g. to use abs path to reference a script. This change aligns the path passed into testutils.RunAssertCommands() to be the same as to testutils.RunCommands(). Fixes kudobuilder#322 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
stuggi
force-pushed
the
fix_assert_command_dir
branch
from
9c51e98
to
b171feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The $PWD is different when running commands in TestStep and TestAssert which makes it required e.g. to use abs path to reference a script. This change aligns the path passed into testutils.RunAssertCommands() to be the same as to testutils.RunCommands().
Fixes #322