Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ws 6.0.0 #43

Closed
lambda-fairy opened this issue Sep 8, 2018 · 5 comments
Closed

Update to ws 6.0.0 #43

lambda-fairy opened this issue Sep 8, 2018 · 5 comments

Comments

@lambda-fairy
Copy link

ws is now up to version 6.0, but koa-websocket still depends on 5.2.

@gentlee
Copy link

gentlee commented Sep 23, 2018

@lfairy don't use this lib, use pure ws.

const WebSocketServer = require('ws').Server;
const Koa = require('koa');

const app = new Koa();
const server = app.listen(process.env.PORT);
const ws = new WebSocketServer({ server });

@shellscape
Copy link

@gentlee that's a teensy bit contrived. there's a lot of heavy lifting that this lib tackles that will have to be re-implemented by using ws directly.

@shellscape
Copy link

Well that's simply not true.

@RWOverdijk
Copy link

@gentlee Did you write something better? Or should I take your comment with a pinch of salt?

@kudos kudos closed this as completed Jul 8, 2019
@nmeylan
Copy link

nmeylan commented Jun 19, 2020

@gentlee comment saved my day because I needed to access to WebSocketServer instance directly and this lib does not expose it.

Repository owner deleted a comment from gentlee Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants