Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single mint might take too much main collateral, so ratio goes below 50% #55

Closed
kuegi opened this issue Jul 22, 2022 · 3 comments
Closed
Labels
enhancement New feature or request ocean-client Is coupled to ocean-client variant of vault-maxi
Milestone

Comments

@kuegi
Copy link
Owner

kuegi commented Jul 22, 2022

maxi should not take the collateral and then fail on the take loan, but handle this case gracefully: recognize it, only take as much as possible and warn user that 50% is reached.

@kuegi kuegi added enhancement New feature or request ocean-client Is coupled to ocean-client variant of vault-maxi labels Jul 22, 2022
@kuegi kuegi added this to the maxi 2.1 milestone Jul 22, 2022
@Krysh90
Copy link
Collaborator

Krysh90 commented Jul 22, 2022

Means if we are outside of the defined collateral range, if we are hitting that 50% mark. That we are sending a warning every 15 minutes.

I guess we will need some kind of guard to not spam warnings

@kuegi
Copy link
Owner Author

kuegi commented Jul 23, 2022

if we want to increase exposure but can't, a warning every 15 minutes is fine IMHO. same as maxi is warning if safetylevel is done.

The user expects the maxi to hold the target range. So maxi needs to tell them if he can't.

kuegi added a commit that referenced this issue Jul 23, 2022
@kuegi
Copy link
Owner Author

kuegi commented Jul 23, 2022

fun fact: this check was already in, just not working.

@kuegi kuegi closed this as completed in 0c1ebdd Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean-client Is coupled to ocean-client variant of vault-maxi
Projects
Status: Done
Development

No branches or pull requests

2 participants