Remove test cases for using bitemporal_option_merge! of ActiveRecord:::Bitemporal::Callbacks #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:Bitemporal::Callbacks
wata727
reviewed
Mar 1, 2023
| end | ||
| context 'employee does not have changes and job_title has changes' do | ||
| let(:update_attributes) { { job_title_attributes: { id: employee.job_title.id, name: "COO" } } } | ||
| it { expect { subject }.to change(employee, :log).from([]).to(%i[before_bitemporal_update after_bitemporal_update]) } |
There was a problem hiding this comment.
I'm surprised that the callback is invoked for an unchanged record. Is this the natural behavior of Active Record?
There was a problem hiding this comment.
This behavior is the same behavior as ActiveRecord.
Even if ActiveRecord instance has no changes, update callbacks will be executed when save method is called.
class Employee < ActiveRecord::Base
after_update :log_update
def log_update
puts "Employee updated"
end
end
employee = Employee.first
employee.save! # "Employee updated" is output
wata727
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added test cases for using bitemporal_option_merge! of ActiveRecord:::Bitemporal::Callbacks in #123 PR.
But specifications that change behavior depending on whether using NestedAttributes or using setter methods are not intended to support by activerecord-bitemporal gem.
It only needs to be tested that association's callbacks are executed when record is updated with NestedAttributes.
This PR organizes only for necessary tests