Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RSpec deprecated warning #132

Merged
merged 1 commit into from
May 8, 2023

Conversation

osyo-manga
Copy link
Collaborator

Fix for RSpec deprecated warning.
e.g.

The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `#<Class:0x000055bd9f501ba0>#swapped_id_previously_was`` not `expect(value).to change `#<Class:0x000055bd9f501ba0>#swapped_id_previously_was``

e.g.

```
The implicit block expectation syntax is deprecated, you should pass a block rather than an argument to `expect` to use the provided block expectation matcher or the matcher must implement `supports_value_expectations?`. e.g  `expect { value }.to change `#<Class:0x000055bd9f501ba0>#swapped_id_previously_was`` not `expect(value).to change `#<Class:0x000055bd9f501ba0>#swapped_id_previously_was``
```
@auto-assign auto-assign bot requested review from motsat and wakasa51 April 25, 2023 12:25
Copy link
Member

@motsat motsat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@wakasa51 wakasa51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@osyo-manga
Copy link
Collaborator Author

Thanks!

@osyo-manga osyo-manga merged commit c4a877f into kufu:master May 8, 2023
7 of 10 checks passed
@osyo-manga osyo-manga deleted the fix-deprecated-warning branch May 8, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants