Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use appraisal in CI #145

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Don't use appraisal in CI #145

merged 1 commit into from
Aug 17, 2023

Conversation

krororo
Copy link
Contributor

@krororo krororo commented Aug 7, 2023

Use the BUNDLE_GEMFILE environment variable to simplify running bundle install.

@auto-assign auto-assign bot requested review from osyo-manga and QWYNG August 7, 2023 01:09
QWYNG
QWYNG approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@QWYNG QWYNG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@krororo Are you going to delete files related to appraisal?

@krororo
Copy link
Contributor Author

krororo commented Aug 9, 2023

@QWYNG

Are you going to delete files related to appraisal?

No, I think appraisal will continue to be useful to manage multiple gemfiles.

mkmn
mkmn approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@mkmn mkmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krororo
Copy link
Contributor Author

krororo commented Aug 17, 2023

Thanks!

@krororo krororo merged commit dc38488 into kufu:master Aug 17, 2023
7 of 10 checks passed
@krororo krororo deleted the dont-use-appraisal-in-ci branch August 17, 2023 06:16
@wata727 wata727 mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkmn mkmn mkmn approved these changes

@QWYNG QWYNG QWYNG approved these changes

@osyo-manga osyo-manga Awaiting requested review from osyo-manga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krororo @mkmn @QWYNG