Reduce update queries if pk is uuid #147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the column of bitemporal_id_key is uuid, the uuid can be generated and specified before insertion into the DB. In this case, there is no need to update bitemporal_id_key in after_create, so the update query can be reduced by one query. Note that for types other than uuid, it is not possible to specify the next pk before inserting it into the DB, so the current logic is maintained.
alpaca-tc
force-pushed
the
assign-bitemporal-id-before-after-create
branch
from
bdf1536
to
d9d4f16
Compare
wata727
reviewed
Aug 17, 2023
| "name" => [nil, "Tom"] | ||
| ), | ||
| previously_force_updated?: false | ||
| ) |
There was a problem hiding this comment.
Should we test here that the swapped_id is equal to the bitemporal_id?
wata727
approved these changes
Aug 17, 2023
mkmn
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the column of bitemporal_id_key is uuid, the uuid can be generated and specified before insertion into the DB. In this case, there is no need to update bitemporal_id_key in after_create, so the update query can be reduced by one query.
Note that for types other than uuid, it is not possible to specify the next pk before inserting it into the DB, so the current logic is maintained.