Remove unneeded unscope values #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unscope values in the
bitemporal_default_scopewere introduced in this commit.Since it is faster to build a query explicitly with a where clause than with a scope call, we hacked the
unscope_valuesthat Active Record uses internally and implemented overrides of valid_from/to and transaction_from/to.However, in the next commit,
where!is replaced by_valid_from_lteqand_valid_to_gt, which userewhere. When usingrewhere, there is no need to override the original condition by unscoped values, so this can simply be removed.