[Proposal] Changed valid_in
to exclude valid_from = to
and valid_to = from
#95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
valid_in
includevalid_from = to
andvalid_to = from
.However, in real-world use cases, you may not want to include
valid_from = to
andvalid_to = from
.e.g. https://github.com/kufu/activerecord-bitemporal/pull/93/files#diff-77aac43b146505859dd74b1fd3e151c0e94174f5abc85475fe1dfba10a5c64bfR513
Proposal
Changed
valid_in
to excludevalid_from = to
andvalid_to = from
.Also,
Range
can be passed as an argument.It behaves differently for
(from...to)
and(from..to)
.