[モバイル対応]各ページへのリンクをハンバーガーメニューで表示する #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinoppyd
reviewed
Apr 23, 2024
kinoppyd
reviewed
Apr 23, 2024
e-ikuta
reviewed
Apr 23, 2024
| > | ||
| <svg stroke="currentColor" fill="currentColor" stroke-width="0" viewBox="0 0 512 512" width="1em" height="1em" class="" role="img" aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" style="color: rgb(112, 109, 101);"><path d="M256 288A144 144 0 1 0 256 0a144 144 0 1 0 0 288zm-94.7 32C72.2 320 0 392.2 0 481.3c0 17 13.8 30.7 30.7 30.7H481.3c17 0 30.7-13.8 30.7-30.7C512 392.2 439.8 320 350.7 320H161.3z"></path></svg> | ||
| <%= I18n.t('nav.profile') %></a> | ||
| </li> |
There was a problem hiding this comment.
チーム機能へのリンクが欲しいです！
mie/app/views/layouts/_header.html.erb
Lines 81 to 91 in 98b2ecc
There was a problem hiding this comment.
こちらで対応しました！
feat: ハンバーガーメニューにチーム画面へのリンクを追加
| <div class="ml-2 mr-4 sm:hidden"> | ||
| <button id="button" type="button" class=""> | ||
| <span id="bars" class=""> | ||
| <i class="fa-solid fa-bars fa-xl"></i> |
There was a problem hiding this comment.
実機（iPhoneSE3）で見たときにハンバーガーメニューの一番上の線がちょっと欠けてしまってました
There was a problem hiding this comment.
こちらも手元で再現できず.... devtoolで画面幅調整しても確認できないのでどうしたものか...
Comment on lines
+14
to
+29
| <label class="flex sm:hidden flex-col items-center mb-2"> | ||
| <span class="mb-2 text-sm font-bold text-[rgb(112,109,101)]"> | ||
| <%= I18n.t('nav.select_locale') %> | ||
| </span> | ||
| <div class="relative box-border w-[16.25em]" data-controller="locale" data-locale-current-value="<%= session[:locale] %>"> | ||
| <select data-action="change->locale#change" class="py-[3px] px-2 min-h-[30px] appearance-none cursor-pointer outline-none rounded-md border border-solid border-[rgb(214,211,208)] bg-white ps-2 pe-8 text-sm text-[rgb(35,34,30)] w-full align-middle"> | ||
| <% grouped_timezones.map do |k, v| %> | ||
| <optgroup label="<%= k %>"> | ||
| <% v.map do |locale| %> | ||
| <option label="<%= locale %>" value="<%= locale %>" <%= locale == session[:locale] ? "selected" : nil %>><%= locale %></option> | ||
| <% end %> | ||
| </optgroup> | ||
| <% end %> | ||
| </select> | ||
| </div> | ||
| </label> |
There was a problem hiding this comment.
iPhone実機で試しました。
タイムゾーンを変更したあとに再度ナビゲーションのスケジュールへのリンクを押してスケジュールを表示するとタイムゾーンが変更されないことがありました。
PCの開発者モードでSEの画面にして試した時は再現しなかったので、iPhoneのChromeアプリ特有の問題かもしれません...。すみません、明確な原因はわかりませんでした🙇♀
There was a problem hiding this comment.
手元で実機で試してみましたが同様の事象は再現しませんでした。。QAのときにもう一度見てみましょうか
kinoppyd
approved these changes
Apr 24, 2024
e-ikuta
approved these changes
Apr 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
やらなかったこと
スクショ