-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageIndexの修正 #1160
PageIndexの修正 #1160
Conversation
✅ Deploy Preview for smarthr-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそうな気がしました 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
意匠としてはLGTMです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ただ下線が引かれたリンクでも良さそうに思ったんですが、BoxLink に近い意匠を増やした方がよさそう、という判断ですか?
その認識であっています。理由は、私がこの機能をnext/prevのショートカットと捉えたからですね。 一方で、この意匠によって特定のユースケース(階層の地続きでないページのIndexとして利用する場合など)で使いづらくなるかもなとも思うので、下線+TEXT_LINKの方が無難なきもしてきました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
課題・背景
やったこと
やらなかったこと
動作確認