fix: add role attribute and visually hidden text #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidermitaina
requested review from
diescake and
im36-123
and removed request for
a team
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
|
Deploy preview for smarthr-ui ready! Built with commit b78a7c4 |
cidermitaina
changed the title
im36-123
previously approved these changes
Sep 25, 2020
|
横から失礼します！:bow: |
wmoai
pushed a commit
that referenced
this pull request
Oct 2, 2020
* fix: add role attribute and visually hidden text * fix: move visually hidden text in loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-151
Overview
Loaderが達成基準 1.1.1 非テキストコンテンツに非適合なので修正しました。
What I did