Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stylelint #1034

Merged
merged 4 commits into from
Oct 12, 2020
Merged

fix: stylelint #1034

merged 4 commits into from
Oct 12, 2020

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Oct 1, 2020 •
edited
Loading

Related URL

kufu/stylelint-config-smarthr#34

Overview

Apply stylelint-config-smarthr that removed deprecated processor

What I did

  • update stylelint-config-smarthr
  • fix stylelint errors that could not be detected because of nested template literal

Capture

@wmoai wmoai requested a review from a team as a code owner October 1, 2020 09:32
@wmoai wmoai self-assigned this Oct 1, 2020
@wmoai wmoai requested review from nabeliwo and zoshigayan and removed request for a team October 1, 2020 09:32
@reg-suit
Copy link

reg-suit bot commented Oct 1, 2020 •
edited
Loading

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@netlify
Copy link

netlify bot commented Oct 1, 2020 •
edited
Loading

Deploy preview for smarthr-ui ready!

Built with commit 39529b9

https://deploy-preview-1034--smarthr-ui.netlify.app

@wmoai wmoai changed the title [WIP] Fix stylelint [WIP] fix: stylelint Oct 1, 2020
@wmoai wmoai changed the title [WIP] fix: stylelint fix: stylelint Oct 8, 2020
nabeliwo
nabeliwo approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@wmoai wmoai merged commit a6a23e4 into master Oct 12, 2020
@wmoai wmoai deleted the fix-stylelint branch October 12, 2020 01:44
@wmoai wmoai mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeliwo nabeliwo nabeliwo approved these changes

@zoshigayan zoshigayan Awaiting requested review from zoshigayan

Assignees

@wmoai wmoai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmoai @nabeliwo