Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backport Shin Color to v6 (SHRUI-232) #1157

Merged
merged 3 commits into from
Nov 24, 2020
Merged

feat: backport Shin Color to v6 (SHRUI-232) #1157

merged 3 commits into from
Nov 24, 2020

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Nov 20, 2020

Related URL

https://smarthr.atlassian.net/browse/SHRUI-232

Overview

v6に新カラーをバックポートする

タグv6.2.0から切ったv6-releaseブランチにマージする

What I did

  • cherry-pick 1c8063a
    • Loaderのstoryの変更はコンフリクトが多かったので落としました(機能に影響はありません)
  • update snapshot
  • lintに引っかかった部分を修正

Capture

@wmoai wmoai requested a review from a team as a code owner November 20, 2020 07:44
@wmoai wmoai self-assigned this Nov 20, 2020
@wmoai wmoai requested review from nabeliwo and cidermitaina and removed request for a team November 20, 2020 07:44
@reg-suit
Copy link

reg-suit bot commented Nov 20, 2020

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@wmoai wmoai changed the title feat: backport Shin Color to v6 feat: backport Shin Color to v6 (SHRUI-232) Nov 20, 2020
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Member

@cidermitaina cidermitaina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます! LGTM🎉

@wmoai wmoai merged commit f462116 into v6-release Nov 24, 2020
@wmoai wmoai deleted the v6-shin-color branch November 24, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants