feat: add Shin color (SHRUI-227) #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoai
requested review from
AtsushiM and
cidermitaina
and removed request for
a team
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
|
Deploy preview for smarthr-ui ready! Built with commit 2c727db |
wmoai
changed the title
cidermitaina
approved these changes
Nov 12, 2020
nabeliwo
reviewed
Nov 12, 2020
|
@nabeliwo このPR自体は |
nabeliwo
approved these changes
Nov 12, 2020
wmoai
added a commit
that referenced
this pull request
Nov 20, 2020
wmoai
added a commit
that referenced
this pull request
Nov 20, 2020
wmoai
added a commit
that referenced
this pull request
Nov 20, 2020
wmoai
added a commit
that referenced
this pull request
Nov 20, 2020
wmoai
added a commit
that referenced
this pull request
Nov 24, 2020
* feat: add Shin color (SHRUI-227) (#1141) * test: update snapshot
wmoai
added a commit
that referenced
this pull request
Nov 24, 2020
* feat: add Shin color (SHRUI-227) (#1141) * test: update snapshot * test: fix lint
wmoai
added a commit
that referenced
this pull request
Nov 26, 2020
* feat: add Shin color (SHRUI-227) (#1141) * test: update snapshot
wmoai
added a commit
that referenced
this pull request
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-227
Overview
新カラーパレットを追加し、使用できるようにします。
What I did
BASE_GREY色を追加createTheme({ palette: shinColorPalette })で新カラーパレットを適用可能やってないこと
defaultPaletteのカラーコードを直書きしている部分がありますが、これらを全て修正するとなると変更が膨大になりバックポートの影響範囲が広がってしまうためこのPRでは対応は行わず、このPR後に行われるdefaultPalette置き換え対応時に合わせて対応したいと思いますCapture