Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table 内 th の詳細度が高すぎる #816

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix: table 内 th の詳細度が高すぎる #816

merged 1 commit into from
Jun 8, 2020

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented May 31, 2020

table 内 th の詳細度が高すぎるため、スタイルのオーバーライドが面倒になってる。
厳密に table > thead > tr > th である必要はまったくない。

これが table > thead > tr > th
こうなる table th

@uknmr uknmr requested a review from nabeliwo May 31, 2020 18:34
@uknmr uknmr requested a review from a team as a code owner May 31, 2020 18:34
@uknmr uknmr mentioned this pull request May 31, 2020
Closed
@reg-suit
Copy link

reg-suit bot commented May 31, 2020

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@netlify
Copy link

netlify bot commented May 31, 2020

Deploy preview for smarthr-ui ready!

Built with commit f5486fa

https://deploy-preview-816--smarthr-ui.netlify.app

AtsushiM
AtsushiM reviewed Jun 1, 2020
View reviewed changes
Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbody 内で th を利用することはそれほどないかもしれませんが thead 指定は合っても良いかもしれません。

@uknmr
Copy link
Collaborator Author

uknmr commented Jun 1, 2020

#802 (comment) で話したんですが、
tbody 内にある th は行ヘッダだと考えられるので列ヘッダと同じ装飾で良いと考えられます。

その場合も詳細度が低い方がオーバーライドしやすくなると考えます。

@AtsushiM
Copy link
Member

AtsushiM commented Jun 1, 2020

@uknmr なるほど、再PRだったんですね。
把握しました 👍

AtsushiM
AtsushiM approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@nabeliwo nabeliwo merged commit 0dcf86a into master Jun 8, 2020
@nabeliwo nabeliwo deleted the fix-table-head-cell branch June 8, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtsushiM AtsushiM AtsushiM approved these changes

@nabeliwo nabeliwo nabeliwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uknmr @AtsushiM @nabeliwo