fix: table 内 th の詳細度が高すぎる #802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for smarthr-ui ready! Built with commit 458636f |
nabeliwo
reviewed
May 25, 2020
| @@ -34,7 +34,7 @@ const Wrapper = styled.table<{ themes: Theme }>` | |||
| border-spacing: 0; | |||
| background-color: ${COLUMN}; | |||
|
|
|||
| & > thead > tr > th { | |||
| th { | |||
There was a problem hiding this comment.
[ask] これまで thead 内の th にしか当たらなかったスタイルが tbody 内の th にも当たるように挙動が変わりましたがデザイン的にはそれで問題ないでしょうか？
There was a problem hiding this comment.
それはヘッダが縦に並ぶ場合の話しだと思うんですが、あくまで th は table header であり、この th への background-color はその table header を表すものだと解釈したので問題ないと思っています!
nabeliwo
previously approved these changes
May 25, 2020
| @@ -34,7 +34,7 @@ const Wrapper = styled.table<{ themes: Theme }>` | |||
| border-spacing: 0; | |||
| background-color: ${COLUMN}; | |||
|
|
|||
| & > thead > tr > th { | |||
| th { | |||
uknmr
force-pushed
the
fix-table-head-cell
branch
from
1b4cd60
to
f5486fa
Compare
|
フォークして PR してたので出し直し。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table内thの詳細度が高すぎるため、スタイルのオーバーライドが面倒になってる。厳密に
table > thead > tr > thである必要はまったくない。table > thead > tr > thtable th