fix: Disable selected items when MultiComboBox is disabled #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yt-ymmt
requested review from
moshisora and
im36-123
and removed request for
a team
yt-ymmt
changed the title
|
Deploy Preview for smarthr-ui ready! Built with commit 8e98aec |
yt-ymmt
changed the title
uknmr
reviewed
May 17, 2021
| onClick={() => onDelete({ value, label })} | ||
| > | ||
| <FaTimesCircleIcon | ||
| size={11} | ||
| color={theme.palette.TEXT_BLACK} | ||
| color={disabled ? theme.color.TEXT_DISABLED : theme.color.TEXT_BLACK} |
There was a problem hiding this comment.
ボタン側で color 指定あると思うので、color: inherit の方がよさそう。
uknmr
reviewed
May 18, 2021
| onClick={() => onDelete({ value, label })} | ||
| > | ||
| <FaTimesCircleIcon | ||
| size={11} | ||
| color={theme.palette.TEXT_BLACK} | ||
| color={disabled ? 'inherit' : theme.color.TEXT_BLACK} |
There was a problem hiding this comment.
説明不足ですいません。
disabled ではないときもボタンカラーがあるのでどちらも inherit でいけます。分岐が不要です。
Suggested change
| color={disabled ? 'inherit' : theme.color.TEXT_BLACK} | |
| color="inherit" |
There was a problem hiding this comment.
@uknmr :aa: 気づかなくてごめんなさい
修正 push しました 🙏
fix: set CircleIcon color to inherit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-390
Overview
What I did
Capture