Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve attributes for Footer #1633

Merged
merged 4 commits into from Jun 14, 2021
Merged

feat: improve attributes for Footer #1633

merged 4 commits into from Jun 14, 2021
+49 −13

Conversation

yt-ymmt
Copy link
Contributor

@yt-ymmt yt-ymmt commented May 31, 2021

Related URL

Overview

  • Footer needed own attributes improved.
  • Footer component needed default class name.

What I did

  • make them accept props as a native HTML element.
  • added class name generator for FieldSet component, and applied it.

@yt-ymmt yt-ymmt self-assigned this May 31, 2021
@yt-ymmt yt-ymmt requested a review from a team as a code owner May 31, 2021 03:31
@yt-ymmt yt-ymmt requested review from diescake and im36-123 and removed request for a team May 31, 2021 03:31
@netlify
Copy link

netlify bot commented May 31, 2021 •
edited

✔️ Deploy Preview for smarthr-ui ready!

🔨 Explore the source changes: 06cafbd

🔍 Inspect the deploy log: https://app.netlify.com/sites/smarthr-ui/deploys/60c6d1f2e9381d0007ca302c

😎 Browse the preview: https://deploy-preview-1633--smarthr-ui.netlify.app/iframe

im36-123
im36-123 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@im36-123 im36-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

nabeliwo
nabeliwo approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@yt-ymmt yt-ymmt merged commit 4d0e17d into kufu:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeliwo nabeliwo nabeliwo approved these changes

@im36-123 im36-123 im36-123 approved these changes

@diescake diescake Awaiting requested review from diescake

Assignees

@yt-ymmt yt-ymmt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yt-ymmt @nabeliwo @im36-123