Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Input interface to conform to the DOM interface #392

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Change Input interface to conform to the DOM interface #392

merged 4 commits into from
Nov 1, 2019

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Oct 17, 2019 •
edited
Loading

change Input interface in order to use with interface of the DOM elements.

  • change to set input type directly
  • change to treat Field Component as custom when it has children

@wmoai wmoai force-pushed the fix-input-interface branch 4 times, most recently from 34e4ee8 to bff5f46 Compare October 20, 2019 14:19
@wmoai wmoai changed the title [WIP] Change Input interface to conform to the DOM interface Change Input interface to conform to the DOM interface Oct 20, 2019
@wmoai wmoai requested a review from a team as a code owner October 31, 2019 09:18
@ghost ghost removed their request for review October 31, 2019 09:18
@nabeliwo nabeliwo merged commit 5f360b9 into kufu:features/ttmz Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeliwo nabeliwo nabeliwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wmoai @nabeliwo