Fix dropdown content position bug #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
ghost
requested review from
|
@im36-123 Please review!! |
im36-123
reviewed
Oct 31, 2019
Comment on lines
40
to
43
| } else { | ||
| position.top = `${scroll.top + triggerRect.top - contentSize.height}px` | ||
| const paddingBottom = 10 | ||
| contentBox.top = `${scroll.top + triggerRect.bottom}px` | ||
| contentBox.maxHeight = `${windowSize.height - triggerRect.bottom - paddingBottom}px` |
There was a problem hiding this comment.
I'm worry about case of the window bottom space is not enough.
This is un extreme example, but in case the below, the user hard to reads context in content.
So I think good solution is to determine the display position of the content based on whether the button is located above or below the window.
|
@im36-123 Thank you for review. Fixed.
|
im36-123
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
☝️ Can no longer scroll upward
Under the following conditions, DropdownContent display position will be strange as shown in the image above.
ideal
For the conditions listed above, the DropdownContent is displayed at the appropriate size below the DropdownTrigger and is scrollable.
what I did
I made it ideal!!!!!!