Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: AccordionPanelのアイコン無し(NoIcon)を削除 #4669

Merged
merged 3 commits into from
May 27, 2024
Merged

feat!: AccordionPanelのアイコン無し(NoIcon)を削除 #4669

merged 3 commits into from
May 27, 2024

Conversation

atzzCokeK
Copy link
Contributor

@atzzCokeK atzzCokeK commented May 23, 2024 •
edited
Loading

Related URL

Overview

  • AccordingPanel の「アイコン無し」バージョンは開ける示唆がUIに存在しないので削除したい。

What I did

  • AccordingPanelからdisplayIconのpropsを削除
  • テストからも不要な点を削除

@atzzCokeK atzzCokeK changed the title feat!: AccordionPanelのアイコン無し(NoIcon)の削除を行う feat!: AccordionPanelのアイコン無し(NoIcon)の削除 May 23, 2024
@atzzCokeK atzzCokeK marked this pull request as ready for review May 24, 2024 07:10
@atzzCokeK atzzCokeK requested a review from a team as a code owner May 24, 2024 07:10
@atzzCokeK atzzCokeK requested review from yt-ymmt and moshisora and removed request for a team May 24, 2024 07:10
@atzzCokeK atzzCokeK requested review from AtsushiM and uknmr May 24, 2024 07:11
@uknmr uknmr changed the title feat!: AccordionPanelのアイコン無し(NoIcon)の削除 feat!: AccordionPanelのアイコン無し(NoIcon)を削除 May 27, 2024
uknmr
uknmr approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コードと Chromatic、ローカルで削除漏れがないか、を確認しました! LGTM

@atzzCokeK atzzCokeK enabled auto-merge (squash) May 27, 2024 09:57
@atzzCokeK atzzCokeK merged commit c12824c into master May 27, 2024
8 checks passed
@atzzCokeK atzzCokeK deleted the SHRUI-714 branch May 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@yt-ymmt yt-ymmt Awaiting requested review from yt-ymmt yt-ymmt is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@AtsushiM AtsushiM Awaiting requested review from AtsushiM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atzzCokeK @uknmr