Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scrollable props for DropdownContent #710

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

im36-123
Copy link
Contributor

@im36-123 im36-123 commented Apr 2, 2020

Added a props called scrollable. This solves the problem of not able to separate scrollable areas from non-scrollable areas in dropdown.

@im36-123 im36-123 requested a review from a team as a code owner April 2, 2020 08:04
@im36-123 im36-123 requested review from nabeliwo and removed request for a team April 2, 2020 08:04
@reg-suit
Copy link

reg-suit bot commented Apr 2, 2020

reg-suit detected visual differences.

Check this report, and review them.

🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for smarthr-ui ready!

Built with commit bc50e64

https://deploy-preview-710--smarthr-ui.netlify.com

@im36-123 im36-123 changed the title [WIP] add scrollable props for DropdownContent add scrollable props for DropdownContent Apr 2, 2020
@im36-123 im36-123 changed the title add scrollable props for DropdownContent [WIP] add scrollable props for DropdownContent Apr 2, 2020
@im36-123 im36-123 changed the title [WIP] add scrollable props for DropdownContent add scrollable props for DropdownContent Apr 2, 2020
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!! LGTM ❤️

@im36-123 im36-123 merged commit 9559404 into master Apr 2, 2020
@im36-123 im36-123 deleted the add-scrollable-props branch April 2, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants