test: add a test whether build files are es5 or not #779
Conversation
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
|
Deploy preview for smarthr-ui ready! Built with commit 1da1d1e |
|
https://circleci.com/gh/kufu/smarthr-ui/5960 is the example of failing on CI |
koba04
force-pushed
the
test-build-assets
branch
2 times, most recently
from
f308c8d
to
849046b
Compare
| @@ -41,6 +42,7 @@ | |||
| "husky": "^4.2.5", | |||
| "jest": "^25.5.4", | |||
| "lint-staged": "^10.2.2", | |||
| "memory-fs": "^0.5.0", | |||
There was a problem hiding this comment.
memory-fs is already deprecated. We can use memfs instead, but an error occurred at an internal of memfs when we use it, so I use memory-fs temporarily. Here is the log that I used memfs.
https://circleci.com/gh/kufu/smarthr-ui/5966
I'll investigate this later.
|
npm seems to be down... So I'll retry after npm has recovered. |
|
I've re-run the CI and have passed it now. |
|
@koba04 It works fine on my local PC. When I've added Great job !! 🎉 |
|
Would you rebase your branch to resolve the conflict ? |
|
@diescake I've fixed the merge conflict, but |
|
kieeeehhhhh 😭 |
|
@diescake I've fixed the merge conflict. |
This adds a test to validate that build files are ES5 compatible.
I've added the test as a script file, not a unit test. It doesn't make sense to be added as a unit test because the test takes about 30 seconds on my local laptop.
The script runs on CI, and you can run the script as
yarn test:build-assetsif you want.