Gtkdoc hdr patches #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents running a bunch of top-level code if the module is ever imported and cleans-up the global namespace.
The other Python scripts already follow this convention.
This prevents a make-time error later if it can't be imported.
|
For the last patch to improve Autoconf check, maybe it should fail gracefully if Python or lxml aren't installed, instead of the hard-fail the patch adds? |
|
Well I implemented it optionally, just like doxygen (which this kind of depends on) so it would make sense. |
This way there's no build failure if Python doesn't exist or if the LXML package can't be imported.
|
Added commit to make it depend on Python and LXML package. |
Merged
|
Mostly LGTM |
|
All the commits have been cherry-picked and are in geany master by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various superficial/cosmetic cleanups to the new Python script.