Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midnight label issue #38

Closed
bisonfoutu opened this issue Jul 19, 2018 · 3 comments
Closed

Midnight label issue #38

bisonfoutu opened this issue Jul 19, 2018 · 3 comments

Comments

@bisonfoutu
Copy link

According to the official Android timepicker, the hour label for displaying midnight should be 00.
It's currently 12, this can be disturbing for users to find out which hour to select, as noon and midnight are displayed with the same value.

@kuhnroyal
Copy link
Owner

kuhnroyal commented Jul 29, 2018

This is actually very interesting, there are so many different layouts out there.
I think currently it is 24, not 12.

https://mdbootstrap.com/javascript/time-picker/
https://github.com/TeamWertarbyte/material-ui-time-picker

We need to figure out what it should look like, then we can change it.

@bisonfoutu
Copy link
Author

Well, I since figured I did not need a timepicker in my app anyway, so I cannot currently check this out, but I clearly remember seeing two hours labelled "12" on the timepicker, and found it so disturbing that I decided to create this issue.

Below is a screenshot of the native Android timepicker I just took on my phone. I believe it should set the standard.

material timepicker

@kuhnroyal
Copy link
Owner

Did you use the moment-adapter? Could be that some moment locale has these weird hours, then it is a moment problem. It should not be happening with the native-adapter.

@bisonfoutu bisonfoutu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants